Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: Only apply lint and format on master branch #1412

Merged
merged 1 commit into from
Sep 23, 2022
Merged

tiflash: Only apply lint and format on master branch #1412

merged 1 commit into from
Sep 23, 2022

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 23, 2022 •
edited
Loading

As we upgrade the compiler version, the static lints checks and format could be changed after the compile toolchain is upgraded.
Only apply lints and format check on the master branch.

Changing TiFlashTestBasic.cpp in master don't raise any lint errors, but the cherry-pick to release-5.4 raise errors.
pingcap/tiflash#5924

purelind
purelind approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purelind purelind merged commit 065b97a into PingCAP-QE:main Sep 23, 2022
@JaySon-Huang JaySon-Huang deleted the patch-1 branch September 23, 2022 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purelind purelind purelind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaySon-Huang @purelind